Support llama3 tokenizer #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FanhaiLu1
reviewed
May 1, 2024
| @@ -0,0 +1,235 @@ | |||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | |||
There was a problem hiding this comment.
Can you move this file to third_part/llama2? It would be better to separate google code vs third party code.
FanhaiLu1
approved these changes
May 1, 2024
jwyang-google
pushed a commit
that referenced
this pull request
May 6, 2024
* Support llama3 tokenizer * Add tiktoken to requirements * Add blobfile to requirements * Fix unit tests * Fix linting issues * Fix pytype errors * Move llama3 tokenizer to third_party directory * Fix pytype error * Update pytype command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.